Skip to content

TST: Fix skipped unit tests in test_ga. Install python-gflags using p… #11091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2015
Merged

TST: Fix skipped unit tests in test_ga. Install python-gflags using p… #11091

merged 1 commit into from
Sep 14, 2015

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 13, 2015

closes #11090

This commit should resolve the following error in the travis build log.

-------------------------------------------------------------
#15 nose.failure.Failure.runTest: need httplib2 and auth libs
-------------------------------------------------------------

Valid Google credentials are required to run the ga unit tests.

@parthea
Copy link
Contributor Author

parthea commented Sep 13, 2015

Here is the output from my local test session:

test_getdata (pandas.io.tests.test_ga.TestGoogle) ... ok
test_iterator (pandas.io.tests.test_ga.TestGoogle) ... ok
test_remove_token_store (pandas.io.tests.test_ga.TestGoogle) ... ok
test_segment (pandas.io.tests.test_ga.TestGoogle) ... ok
test_v2_advanced_segment_format (pandas.io.tests.test_ga.TestGoogle) ... ok
test_v2_dynamic_segment_format (pandas.io.tests.test_ga.TestGoogle) ... ok
test_v3_advanced_segment_common_format (pandas.io.tests.test_ga.TestGoogle) ... ok
test_v3_advanced_segment_weird_format (pandas.io.tests.test_ga.TestGoogle) ... ok
test_v3_advanced_segment_with_underscore_format (pandas.io.tests.test_ga.TestGoogle) ... ok

----------------------------------------------------------------------
Ran 9 tests in 3.370s

OK

jreback
jreback reviewed Sep 13, 2015
View reviewed changes
pandas/io/tests/test_ga.py
@@ -142,7 +145,8 @@ def test_segment(self):
end_date=end_date,
segment=-2,
dimensions=['date', 'hour'],
parse_dates={'ts': ['date', 'hour']})
parse_dates={'ts': ['date', 'hour']},
index_col=0)

assert isinstance(df, DataFrame)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix these tests to use either:

self.assertIsInstance(....) testing or

just compare vs an expected frame (e.g. assert_frame_equal)

@jreback jreback added Testing pandas testing functions or related to the test suite Google I/O labels Sep 13, 2015
@jreback jreback added this to the 0.17.0 milestone Sep 13, 2015
@parthea
Copy link
Contributor Author

parthea commented Sep 14, 2015

I've updated the tests as per the comments. The import error is gone in my latest commit. See job https://travis-ci.org/parthea/pandas/jobs/80171740

The new reason for skipped tests is authentication error as the tests require valid google credentials.

#16 pandas.io.tests.test_ga.TestGoogle.test_getdata: authentication error
#17 pandas.io.tests.test_ga.TestGoogle.test_iterator: authentication error
#18 pandas.io.tests.test_ga.TestGoogle.test_segment: authentication error

I've confirmed that the tests pass with valid credentials.

jreback added a commit that referenced this pull request Sep 14, 2015
@jreback
Merge pull request #11091 from parthea/ga-test-failure
9be2180 
TST: Fix skipped unit tests in test_ga. Install python-gflags using p…
@jreback jreback merged commit 9be2180 into pandas-dev:master Sep 14, 2015
@jreback
Copy link
Contributor

jreback commented Sep 14, 2015

thanks!

@parthea parthea deleted the ga-test-failure branch September 14, 2015 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Unit tests in test_ga are being skipped
2 participants
@parthea @jreback